Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support ...................................................................... Patch Set 3: (4 comments) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/12ce160b_f13e25bf?usp=email : PS2, Line 439: } else { > You can move this code path above as an early return. Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/1f550c1d_fd38f9cf?usp=email : PS2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI) > these "else" here and below are not needed since you are doing early return. Done File tests/gprs_routing_area/gprs_routing_area_test.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/4a3591c6_07995963?usp=email : PS2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */ > registered? I switched to a different wording. https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/277d8359_0465ad6c?usp=email : PS2, Line 542: void test_routing_area_mv_utran_geran_reject(void) > I think it's worth explaining here that this is an implementation decision we > took and that it's not […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 Gerrit-Change-Number: 40813 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 21 Aug 2025 16:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
