On Wed, May 22, 2024 at 1:53 AM Ulrich Mueller <u...@gentoo.org> wrote: > Please provide an explanation what problem this patch fixes. > > Why is calling unpack on sig files bad? It should silently skip files > with unknown extensions.
The main reason is that Portage does not *silently* skip unknown extensions in unpack. For example: >>> Unpacking freerdp-2.11.7.tar.gz.asc to >>> /x/portage/net-misc/freerdp-2.11.7/work unpack freerdp-2.11.7.tar.gz.asc: file format not recognized. Ignoring. The other reason would be the small/trivial efficiency gain; there is no point in calling unpack on a file it won't be able to process.