Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files

[Ulrich Mueller]

>>>>> On Wed, 22 May 2024, Mike Gilbert wrote:

> Signed-off-by: Mike Gilbert <flop...@gentoo.org>
> ---
>  eclass/verify-sig.eclass | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

> diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> index b74ed78290aa..4d48c9ed8503 100644
> --- a/eclass/verify-sig.eclass
> +++ b/eclass/verify-sig.eclass
> @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
>                       verify-sig_verify_detached \
>                               "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
>               done
> -     fi
 
> -     # finally, unpack the distfiles
> -     default_src_unpack
> +             # finally, unpack the distfiles
> +             if [[ ${#distfiles[@]} -gt 0 ]]; then
> +                     unpack "${distfiles[@]}"
> +             fi
> +     else
> +             default_src_unpack
> +     fi
>  }
 
>  fi

Please provide an explanation what problem this patch fixes.

Why is calling unpack on sig files bad? It should silently skip files
with unknown extensions.

Ulrich

signature.asc
Description: PGP signature