On 01/27/2018 02:47 PM, Michał Górny wrote: >> * >> * Please download fileN from >> * wherever fileN can be found >> * and move it to $DISTDIR/subdirN > > Do you really believe this to be more friendly than a helper that places > all the files in correct directories?
Well, it's no worse than what we have now, because it is what we have now. And if having an "edistadd" helper is easier, then it could check the computed hash against the manifest before moving it under $DISTDIR. If the computed hash and manifest hash don't match, a decent error message can be displayed. The person who asked for it and the person who are implementing this prefer hash(filename), so by all means, do that. The two stated reasons for rejecting hash(filedata) just stood out to me as not very compelling. Maybe Robin's comment from the bug is a better reason? > Checksum from the manifest is problematic because not every file in > distfiles is in a Manifest (there are whitelisted files). (https://bugs.gentoo.org/534528#c29)