On 07/27/2017 04:11 PM, Michał Górny wrote: >> Right, so github automatically closes pull requests when encountering >> Closes, that doesn't indicate that Closes can't be used for other >> platforms to do similar things, or closing things manually if provided >> through other channels. The current wording indicates it is only for >> Github use "to automatically close a GitHub pull request," > ...which is the only purpose it's being used for right now, and I > seriously doubt there will be any other use in the near future.
That doesn't mean we shouldn't prepare for it in our specification, why shouldn't I be able to use it for closing a pull request provided through bitbucket or a git request-pull from my private gitolite? There is absolutely no reason to mention github in the GLEP versus making it a generic tag for closing a pull request. -- Kristian Fiskerstrand OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3
signature.asc
Description: OpenPGP digital signature
