Michał Górny <mgo...@gentoo.org> writes:
>> +# @FUNCTION: erebar
>> +# @USAGE: <targets>
>> +# @DESCRIPTION:
>> +# Run rebar with verbose flag. Die on failure.
>> +erebar() {
>> + debug-print-function ${FUNCNAME} "${@}"
>> +
>> + (( $# > 0 )) || die "erebar: at least one target is required"
>> +
>> + local -x ERL_LIBS="${EPREFIX}$(get_erl_libs)"
>> + rebar -v skip_deps=true "$@" || die "rebar $@ failed"
>
> Maybe 'die -n', for consistency with emake?Yes, just for consitency... >> +# @FUNCTION: rebar_src_prepare >> +# @DESCRIPTION: >> +# Prevent rebar from fetching in compiling dependencies. Set version in >> project > > I think this sentence is incorrect. Yes, "in" -> "and". Thanks for catching this! > I think I have no further comments, so the two things above > considered, looks good to go. Thank you for review! I have pushed eclass along with tests. Feel free to comment on tests later. -- Amadeusz Żołnowski
signature.asc
Description: PGP signature
