On Fri, 20 May 2016 16:00:38 -0400 Ian Stakenvicius <a...@gentoo.org> wrote:
> On 20/05/16 11:49 AM, Michał Górny wrote: > > On Fri, 20 May 2016 11:40:39 -0400 > > Michael Orlitzky <m...@gentoo.org> wrote: > > > >> On 05/20/2016 11:34 AM, Daniel Campbell wrote: > >>> > >>> ...and the user has this in their install.mask file: > >>> > >>> [bash-completion] > >>> path=/some/other/path > >>> desc=some other description > >>> > >> > >> I don't think that's allowed; the groups are specified by each > >> repository's metadata/install-mask.conf, not by the users. > >> > >> Although, you can ask the same question about overlays that have > >> group-name clashes. Is that an error, or would we use the one from the > >> overlay? > > > > Oh, you are correct. Originally I planned to handle that, and I forgot > > about it. > > > > Since there can be multiple paths, we have two options: either > > override, or amend like systemd does with *.d files. I think the former > > would be less surprising. > > > > Override is simple -- entry from next file overrides previous, > > and discards all data. > > > > Amending is harder. Description from next file overrides former, but > > paths are appended. But there is special 'path=' (empty) that discards > > all previous values and starts over. I don't think that's really a good > > idea for repos. > > > I'd vote override, simply because it would match the same behaviour > seen with eclasses and we could leverage the same 'masters =' in > repos.conf to manage order when dealing with multiple repos. I thought about this more and decided we can't accept collisions at all, since INSTALL_MASK is defined globally and not per ebuild. We don't want the same mask to mean different things in different repositories after all, do we? ;-) -- Best regards, Michał Górny <http://dev.gentoo.org/~mgorny/>
pgpxtSsgLw5RE.pgp
Description: OpenPGP digital signature
