On 08/14/2015 01:10 PM, Andrew Savchenko wrote: > On Fri, 14 Aug 2015 02:11:09 -0700 Daniel Campbell (zlg) wrote: >> I honestly don't see the point of this when `git log` or even `git >> diff` or standard `diff` will tell you if what's in your overlay >> differs from the source. With some bash magic it could even be >> automated. The point of that 'feature' is to see what, if anything, >> has changed between one's overlay and Gentoo's running tree. A diff >> would not only be able to tell you *if* anything changed, but also >> *what*, without adding around 5-7 extra bytes per ebuild. Sure, it's >> only bytes, but when multiplied against the number of ebuilds we have, >> it can make a few hundred KB difference. When expanded, that number >> multiplies. Is it worth adding this extra bloat to something that a >> standard utility can expose better than a hash? > > Agree here. Also I don't like the idea of post-modifying content of > signed commits: files developers committed to the tree should be > the same users get. As a side effect this will simplify tree > consistency checks and forensics. >
The files are already modified (e.g. Manifest) for rsync, so this arguments becomes a moot point.
