On Mon, Jun 01, 2015 at 07:24:26PM +0200, Michał Górny wrote:
> Dnia 2015-06-01, o godz. 12:13:52
> William Hubbs <willi...@gentoo.org> napisał(a):
> 
> > # @FUNCTION: s6_get_servicedir
> > # @DESCRIPTION:
> > # Output the path for the s6 service directory (not including ${D}).
> > s6_get_servicedir() {
> >     has "${EAPI:-0}" 0 1 2 && ! use prefix && EPREFIX=
> 
> How about killing some support for ancient EAPIs? The less people can
> use them, the better for ebuild migration.

That's easy enough. In that case I would start support at eapi 5.

> 
> >     debug-print-function ${FUNCNAME} "${@}"
> > 
> >     echo "${EPREFIX}$(_s6_get_servicedir)"
> > }
> > 
> > # @FUNCTION: s6_doservice
> > # @USAGE: servicename run finish
> 
> Please don't name it 'do*' if it doesn't match the usual do-function
> usage, i.e. 'dofoo file1 file2...'. That's why I created
> 'systemd_install_serviced' and not 'doserviced'.

Ok, it would be easy enough to name it s6_install_service. There can't
be a do* in this case then because an s6 service is not just a simple
file.

William

Attachment: signature.asc
Description: Digital signature

Reply via email to