On Wed, 18 Feb 2015 15:13:31 -0500 Michael Orlitzky wrote: > The topic of a review workflow comes up frequently, but Gitlab, Gerrit, > etc. are blocked on a host of other problems that may never be resolved. > It would still be nice to be able to request reviews somewhere, and for > ebuilds, a mailing list combined with a threaded MUA works fine. > > Would anyone else find gentoo-review@lists.g.o useful? I think a lot of > simple problems could be quickly caught with a second set of eyeballs. > > There is already gentoo-dev-help@, but it's /very/ quiet. If we could > all agree to subscribe and do reviews there, that would work as well.
Please explain this proposal in more detail. If code review is supposed to be mandatory for each commit, this will effectively stop development. If it is supposed to be used as an auxiliary but not mandatory tool, e.g. when people are unsure of their changes or need to review proxy-maintained commits and so on, I fully support this idea. Best regards, Andrew Savchenko
pgp2yMNj5jcLX.pgp
Description: PGP signature