On Sun, 21 Apr 2013 17:05:49 +0200 Alexis Ballier <[email protected]> wrote:
> On Sun, 21 Apr 2013 20:53:28 +0800 > Ben de Groot <[email protected]> wrote: > > > > > > PS: btw, some hunks are weird in your commit, a locale issue ? > > > > > > > No, just a line in my vimrc that removes trailing whitespace. > > > > You should probably disable it or remove trailing whitespaces in a > separate commit though. Having functional changes mixed with > whitespace/cosmetics in a single commit makes it hard to read > and understand. You should just convert the commit diff to not include space changes. > [This is really a nitpick, no need to have a debate, it's only a > suggestion ;)] [There are two sides to a debate; so, the nitpick goes both ways. ;)] -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : [email protected] GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
signature.asc
Description: PGP signature
