On Sun, 21 Apr 2013 20:53:28 +0800
Ben de Groot <yng...@gentoo.org> wrote:
> >
> > PS: btw, some hunks are weird in your commit, a locale issue ?
> >
> 
> No, just a line in my vimrc that removes trailing whitespace.
> 

You should probably disable it or remove trailing whitespaces in a
separate commit though. Having functional changes mixed with
whitespace/cosmetics in a single commit makes it hard to read
and understand.

[This is really a nitpick, no need to have a debate, it's only a
suggestion ;)]

Alexis.

Reply via email to