El lun, 30-04-2012 a las 10:05 -0700, Zac Medico escribió: > On 04/29/2012 09:45 AM, Petteri Räty wrote: > > On 15.04.2012 17:12, Pacho Ramos wrote: > >> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió: > >>> On Sun, 15 Apr 2012 11:59:50 +0200 > >>> Pacho Ramos <pa...@gentoo.org> wrote: > >>> > >>>> I am unsure about validate_desktop_entries() utility. It's currently > >>>> provided by eutils.eclass and only called by net-firewall/fwbuilder. > >>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless > >>>> as it's not used by most of packages, and calling it from a lot of > >>>> eclasses/ebuilds doesn't sound me like a good idea. > >>>> > >>>> What do you think? > >>> > >>> Agreed. It should be in repoman. > >>> > >> > >> The check needs to be run over desktop file going to be installed, not > >> sure how repoman can handle it, it looked to me more like a emerge job > >> (like is done with other qa checks run before installation) > > > > There's actually already code in repoman that runs > > desktop-file-validate. It of course only works for installed packages. > > Someone could make it run runtime too. > > The repoman code works on $FILESDIR. It looks like we also want to run > it after src_install. > > Also, it looks like we might need to handle a special case for Konqueror > Service Menus: > > https://bugs.gentoo.org/show_bug.cgi?id=414125
Yes, I would like to also check other desktop files than those coming from FILESDIR
signature.asc
Description: This is a digitally signed message part
