On 04/22/2012 10:04 PM, Steven J Long wrote: > It seems there's two major cases, with autotools or without. In either case, > epatch_user should be called after Gentoo patches have been applied. > > Why not make epatch_user set a variable to indicate that patches have been > applied, and only apply the patches on the first call? > > Then eautoreconf could call it before calling autoconf (and the ebuild > wouldn't need to worry about it.) And any custom src_prepare function could > call it when needed, if it needed to be done during the phase, and not > after. > > After src_prepare, the PM could just call it unconditionally, since it will > not apply the patches again, if it's already been called by the ebuild. > > Does that make sense?
Yeah, sounds roughly equivalent to Ciaran's suggested "apply_user_patches_here" approach [1], except that Ciaran suggested to make it an error if src_prepare doesn't call apply_user_patches_here (so people don't forget to call it when they should). [1] http://archives.gentoo.org/gentoo-dev/msg_c228be85e0c4e577ad194e6004d59062.xml -- Thanks, Zac
