Ryan Hill wrote: > Zac Medico wrote: >> Funtoo has support for FEATURES=localpatch, which does the epatch_user >> thing before src_prepare. I think it should really go after src_prepare, >> in order to apply patches after those that src_prepare may apply >> (avoiding possible conflicts). > > I agree. > >> The reason that Funtoo's FEATURES=localpatch applies patches before >> src_prepare is that it's common for eautoreconf to be called inside >> src_prepare, and applying patches after src_prepare can create a need to >> call eautoreconf a second time. > > Well that could waste a bit of time but is pretty much harmless, no? And > the existing usages of epatch_user (other than autotools-utils) don't > eautoreconf anyways, nor should they in case the package doesn't use > autotools. > Zac Medico wrote: > The nice thing about delegating the epatch_user call to the ebuild/eclass > is that it allows the epatch_user call be positioned directly before an > eautoreconf call when appropriate.
It seems there's two major cases, with autotools or without. In either case, epatch_user should be called after Gentoo patches have been applied. Why not make epatch_user set a variable to indicate that patches have been applied, and only apply the patches on the first call? Then eautoreconf could call it before calling autoconf (and the ebuild wouldn't need to worry about it.) And any custom src_prepare function could call it when needed, if it needed to be done during the phase, and not after. After src_prepare, the PM could just call it unconditionally, since it will not apply the patches again, if it's already been called by the ebuild. Does that make sense? Steve. -- #friendly-coders -- We're friendly, but we're not /that/ friendly ;-)
