On Wednesday 01 February 2012 15:30:16 Michał Górny wrote: > On Wed, 1 Feb 2012 15:05:40 -0500 Mike Frysinger wrote: > > # You have to specify the off_t size ... I have no idea how to > > extract that # information out of the binary executable myself. > > Basically you pass in # the size of the off_t type (in bytes) on the > > machine that built the pdv # archive. > > Can't you use 'file' to determine the host type and just assume off_t > for it?
i'm not looking for feedback on the unpack_{makeself,pdv} at this point in
time. i'll look after the eutils->unpacker migration is done.
> > # @FUNCTION: unpacker
>
> Wrong name.
fixed
> > # @USAGE: [archives that we will unpack]
> > # @RETURN: Dependencies needed to unpack all the archives
> > # @DESCRIPTION:
> > # Walk all the specified files (defaults to $SRC_URI) and figure out
> > the # dependencies that are needed to unpack things.
> > #
> > # Note: USE flags are not yet handled.
> > unpacker_src_uri_depends() {
> >
> > local uri deps d
> >
> > [[ $# -eq 0 ]] && set -- ${SRC_URI}
> >
> > for uri in "$@" ; do
> >
> > case ${uri} in
> > *.rar|*.RAR)
> >
> > d="app-arch/unrar" ;;
> >
> > *.7z)
> >
> > d="app-arch/p7zip" ;;
>
> Where are those file formats handled? You don't seem to fallback to
> 'unpack' anywhere too.
eh ? this func doesn't do unpacking, just ${SRC_URI}<->${DEPEND} matching.
> And I think you should consider using 'file --mime' rather than
> relying on format descriptions not ever changing/differing due to
> subtle differences.
probably worth looking at
-mike
signature.asc
Description: This is a digitally signed message part.
