On Wed, 1 Feb 2012 15:05:40 -0500 Mike Frysinger <[email protected]> wrote:
> # You have to specify the off_t size ... I have no idea how to
> extract that # information out of the binary executable myself.
> Basically you pass in # the size of the off_t type (in bytes) on the
> machine that built the pdv # archive.
Can't you use 'file' to determine the host type and just assume off_t
for it?
> # @FUNCTION: unpack_makeself
> # @USAGE: [file to unpack] [offset] [tail|dd]
> # @DESCRIPTION:
> # Unpack those pesky makeself generated files ...
> # They're shell scripts with the binary package tagged onto
> # the end of the archive. Loki utilized the format as does
> # many other game companies.
> #
> # If the file is not specified, then ${A} is used. If the
> # offset is not specified then we will attempt to extract
> # the proper offset from the script itself.
The third argument is not explained.
> unpack_makeself() {
> local src_input=${1:-${A}}
What if ${A} contains more than a single file? Well, what is this for
anyway?
> case ${exe} in
> tail) exe="tail -n +${skip} '${src}'";;
> dd) exe="dd ibs=${skip} skip=1
> if='${src}'";; *) die "makeself cant handle exe
> '${exe}'" esac
What is the use of that?
> # @FUNCTION: unpacker
Wrong name.
> # @USAGE: [archives that we will unpack]
> # @RETURN: Dependencies needed to unpack all the archives
> # @DESCRIPTION:
> # Walk all the specified files (defaults to $SRC_URI) and figure out
> the # dependencies that are needed to unpack things.
> #
> # Note: USE flags are not yet handled.
> unpacker_src_uri_depends() {
> local uri deps d
>
> [[ $# -eq 0 ]] && set -- ${SRC_URI}
>
> for uri in "$@" ; do
> case ${uri} in
> *.rar|*.RAR)
> d="app-arch/unrar" ;;
> *.7z)
> d="app-arch/p7zip" ;;
Where are those file formats handled? You don't seem to fallback to
'unpack' anywhere too.
And I think you should consider using 'file --mime' rather than
relying on format descriptions not ever changing/differing due to
subtle differences.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
