On Sat, 17 Jan 2009 14:04:28 +0200
Petteri Räty <betelge...@gentoo.org> wrote:

> # @FUNCTION: go-mono_src_unpack
> # @DESCRIPTION: Runs default()
> go-mono_src_unpack() {
>       default
> }
> 
> What's the point? The ones from base.eclass should be doing the same
> thing as the default ones any way.
> 
> The same goes for src_compile.

To make sure we know what we are getting and don't have to go searching
through more than one eclass to see exactly what a function does.

> local COMMONDOC=( AUTHORS ChangeLog README TODO )
> 
> I wouldn't write local variables with capital letters.

Sure, we can paint the bikeshed green :-)

/PA

Reply via email to