Thomas Anderson wrote: > On Sat, Sep 06, 2008 at 12:43:12PM +0100, Steve Long wrote: >> Christian Faulhammer wrote: >> >> > Zac Medico <[EMAIL PROTECTED]>: >> >> Both approaches are essentially equivalent but it's a little simpler >> >> for ebuild writer if they don't have to customize the output file >> >> name. >> > >> > One needs exceptions for all kind of systems, for example I had to >> > workaround Trac which adds ?format=raw to a tarball URI. There seems >> > to be a solution in Trac as the guys from fedarahosted fixed the two I >> > needed (tmpwatch, mlocate). So the -> operator is quite useful and I >> > agree with David that the functionality is doubled. >> > >> Clearly src-uri transformation is useful. Others have given examples of >> how it would be useful to an eclass. Irrespective of how the actual >> transform is done in the ;sf=tbz2 case, both _are_ valid use-cases. > > Sure they may be valid use cases, but the issue is whether the > ;sf=tar.bz2 code is duplicated from '->'. I don't see any reason why you > can't use '->' to handle ;sf=tbz2, so they are duplicated. Since '->' > can be used in more circumstances(SRC_URI="http://foo.com/2.3/foo.bz2 > -> ${P}.tar.bz2" comes to mind), we don't need ;sf=tbz2.
You're confusing the code which implements, with the API thus provided. It's totally irrelevant whether the same code handles the functionality or not. (That's what encapsulation is about.)
