On Tue, 09 Oct 2007 08:13:31 +0100
Roy Marples <[EMAIL PROTECTED]> wrote:
> grep '^!' "${i}" | tr ' ' '=' |sort|uniq >> "${T}/jobs"
> Could be done with a 1 sed and 1 sort call, but whatever floats your
> boat.

well as this is very inspired from texlive install-pkg.sh script, I'd
prefer not differing that much.

> if [ "${f/config/}" != "${f}" ]
> Should be
> if [ "${f#*config*}" != "${f}" ]

changed that one, the "semantics" looks better indeed; what is wanted
here is to exclude $f containing "config". Am I missing something when
I understand it as the exact same thing but more readable ?

> return $([ -f "${mark}" ])
> Could be written as
> [ -f "${mark}" ]

thanks, too much influence from other programming languages...


Attached try3, with some more comments on the functions of
texlive-module.eclass.

Alexis.

Attachment: texlive-module.eclass
Description: Binary data

Attachment: texlive-common.eclass
Description: Binary data

Attachment: signature.asc
Description: PGP signature

Reply via email to