On Tue, 2007-10-09 at 01:03 +0200, Alexis Ballier wrote:
> On Mon, 8 Oct 2007 23:47:31 +0200
> Alexis Ballier <[EMAIL PROTECTED]> wrote:
> 
> > Hi list, 
> 
> 
> Try 2, after dberkholz comments on irc: 
> - replaced test by []
> - removed useless use of cat
> 
> 
> Alexis.

grep '^!' "${i}" | tr ' ' '=' |sort|uniq >> "${T}/jobs"
Could be done with a 1 sed and 1 sort call, but whatever floats your
boat.

case ${command} in
Should quote command here

if [ "${f/config/}" != "${f}" ]
Should be
if [ "${f#*config*}" != "${f}" ]

return $([ -f "${mark}" ])
Could be written as
[ -f "${mark}" ]

Thanks

Roy

-- 
[EMAIL PROTECTED] mailing list

Reply via email to