On Mon, 2007-10-01 at 20:22 -0400, Mike Frysinger wrote: > "better readability" is a pretty subjective claim ...
Many things are subjective - one mans good is another mans bad. /me shrugs > i'd say that changing > things from doing a case match against proper character classes to doing a > printf against arbitrary character ranges (which btw are not locale safe, so > i imagine you've introduced a regression there) is not "better". but i'm not > the maintainer of said eclass. That is why the case match is like so [0-9] Should be safe - every language should operate in base 10 -|.|_ Exact match * If it's not the above, treat it like a letter So there shouldn't be any regressions with version numbers here as I've cunningly avoided the locale trap. > > > but I find interesting that > > > you ripped Ciaran's copyright while leaving the "Prod ciaranm if you > > > find something it can't handle" comment. > > > > I copied and pasted the comments for the most part. Sorry for leaving that > > bit in. And I thought that the Gentoo Foundation had the copyright? > > it does. and if it doesnt, punt the file and rewrite it from scratch. Well, this should constitute a rewrite from scratch. Thanks Roy -- [EMAIL PROTECTED] mailing list
