On 06:58 Fri 21 Sep , Alistair Bush wrote: > normally java-pkg_do_write_ is called to write the package.env out, as > can be seen, and is the default behavior for the function. What I am > adding is the ability to _do_write of a "[virtual|provider].env" file. > While at present it only contains 3 variables, I see no reason why > eventually it will not include other vars that are shared between the > package.env and "virtual.env" ( e.g DESCRIPTION ) > > Therefore this change can be summarized as > > + if [[ $1 != provider ]]; then > #Do the default package.env behaviour > + else > + #Create a "virtual.env" file. This will only be invoked by > + #ebuilds that inherit java-virtuals.eclass > + fi > > I could very well reflactor the java-pkg_do_write_ function back to its > current state and create a new function java-pkg_do_write_virtual to be > called by java-virtuals-2.eclass. > > The documentation could (and will) be updated to more correctly reflect > whats happening.
I'm concerned about code duplication, because that's what it looks like. Refactoring might be a good idea. Thanks, Donnie -- [EMAIL PROTECTED] mailing list
