On 7/23/06, John Jawed <[EMAIL PROTECTED]> wrote:
Nice work on this, it's looking good now. Is there a reason the leading asterisk was dropped? Having it there might be good for readability as well as keeping in line with the "look here" (einfo, eerror, ewarn, etc) motif in portage.
I was indeed attempting to keep with the established look and feel of Portage tools here, and in this case the appearance of the "emerge -a" prompt seemed a more appropriate model than the appearance of the non-interactive einfo(), ewarn(), and eerror() messages. The reason the latter are prefixed with colored asterisks is because they're non-interactive and need some way to catch the user's eye amidst other messages flying by in the terminal. In contrast, an interactive prompt such as "emerge -a" doesn't really need to stand out in the same way because it's going to sit there in the user's face until it receives input. I did make the prompt text bold to be consistent with the look of "emerge -a", and this consistency is what we should go for IMO because the only time users are likely to run into einput.eclass's prompts is when it's being called from an ebuild running in an "emerge" session. I feel it's quite arguable which style looks better (bolded or asterisked), and if it's decided to go with fuchsia asterisks for einput's prompts after all, emerge's prompts should also be changed to maintain consistency. -- gentoo-dev@gentoo.org mailing list
