-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Sun, 12 Feb 2006, Daniel Drake wrote:
Henrik Brix Andersen wrote:
> 3. Always record contributions by name
>
> If you commit something in response to a bug report that has been filed,
> always thank the user by full name (and bug number) in the ChangeLog and
> commit message.
>
> Do the above even if you already knew about the bug (i.e. you would have
> committed the same fix even if the user hadn't alerted you).
>
> This also applies for ebuild requests, ebuild submissions, and version
> bump requests/submissions. Might sound pointless for 'trivial'
> reports/requests but it is important to credit the user if they have
> gone to the trouble of filing a bug.
I don't really get this part. Why should I give credit to someone else
for providing a fix for a bug which I already fixed myself locally?
Maybe not if you have already done the work. I was thinking more of the
scenario, upstream does a release. You are on the mailing list so you know
about the new version. You decide you'll bump it in portage tomorrow.
Well, the user did the work, too, and doesn't know that you did it (if I
understand your case correctly). So the user deserves as much credit as you do.
(At least, from the user's point of view. Consider, if you don't credit
the user, to the user it just looks like you took the fix and called it
your own. You know that's not the case, but the user doesn't and likely
is justifiably upset.)
The issue I am trying to approach is that the user who filed the bug is
likely to check the ChangeLog, and will be mildly upset if they are not
mentioned yet it appears that their bug report *may* have triggered the bump.
By the way, I really like the proposal which triggered this discussion.
Regards,
Ferris
- --
Ferris McCormick (P44646, MI) <[EMAIL PROTECTED]>
Developer, Gentoo Linux (Devrel, Sparc)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFD79mAQa6M3+I///cRAlZMAJ9F8sew14KN4jmdqwHHVVFrQcYdnwCeMTcD
r9bihtdF/W7cU8bqMy1OEM8=
=p+Fd
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list