Would it be possible to do a new RC that addresses the LICENSE issue that Jean-Baptiste Onofré mentioned? If you do a new RC, then switching to the standard DISCLAIMER could be done too.
One technical issue with the vote email is that it uses the wrong link for the KEYS file. Votes should point to: https://downloads.apache.org/incubator/teaclave/KEYS which is a mirror of: https://dist.apache.org/repos/dist/release/incubator/teaclave/KEYS The downloads.apache.org link is preferred. You shouldn't link to https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS The files seem to match at the moment but they could get out of sync. Is there a reason to even keep the 'dev' one? One minor nit for me is that I think the release files should not have 'rc.1' in the name. This means you won't need to rename the files when you release them. It is good to have the 'rc.1' name in the directory name (as you already have). https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.4.0-rc.1/ Could you also remove the old RCs? https://dist.apache.org/repos/dist/dev/incubator/teaclave/ Once the vote completes, the RCs should be removed (or moved to the release area if the vote passes). On 2025/03/05 07:06:05 Gordon wrote: > LGTM, thanks. > > +1 > > > On Feb 18, 2025, at 8:20 PM, Yuan Zhuang <yu...@apache.org> wrote: > > > > Hi Community, > > > > I am pleased to be calling this vote for the release of > > Apache Teaclave TrustZone SDK (incubating) 0.4.0 (release candidate 1). > > > > The vote from Apache Teaclave (incubating) community has PASSED with 5 > > +1 votes (4 binding). > > The vote thread is > > https://lists.apache.org/thread/g1b3xlkoywp4kozcqb8oyxr52h7owkjq. > > The result thread is > > https://lists.apache.org/thread/9yxkcf6ogvllnb4obv9rlz3lfc4ot799. > > > > The release candidate to be voted over is available at: > > - > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.4.0-rc.1/ > > > > The release note is available in: > > - > > https://github.com/apache/incubator-teaclave-trustzone-sdk/releases/tag/v0.4.0-rc1 > > > > The release candidate is signed with a GPG key available at: > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS > > Instructions to verify the source tar: > > - https://teaclave.apache.org/download/#verify-the-integrity-of-the-files > > > > Quick Building and Testing from source: > > ``` > > $ wget > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.4.0-rc.1/apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating.tar.gz > > > > $ tar zxvf apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating.tar.gz \ > > && cd apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating > > > > # This will take about 30 minutes. Once everything is finished, we’ll see > > # the prompt: "+ popd /teaclave-trustzone-sdk/ci": > > $ docker run --rm -it -v$(pwd):/teaclave-trustzone-sdk -w \ > > /teaclave-trustzone-sdk yuanz0/teaclave-trustzone-sdk:ubuntu-24.04 \ > > bash -c "./setup.sh && (./build_optee_libraries.sh optee) && source \ > > environment && make && (cd ci && ./ci.sh)" > > > > ``` > > > > A release checklist for reference: > > - > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > The vote will be open for at least 72 hours. Anyone can participate > > in testing and voting, please feel free to try out the release candidate > > and provide your votes to this thread explicitly. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > > > Best, > > > > Yuan Zhuang > > Apache Teaclave (incubating) PPMC > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
