+1 (non-binding) I checked - incubating in name - DISCLAIMER exists - Notice is good - no unexpected binary files - release can be built from source
Best. On Mon, Feb 24, 2025 at 12:21 AM Yuan Zhuang <yu...@apache.org> wrote: > Thanks for your comment! > > Regarding the DISCLAIMER_WIP: > This version of the disclaimer is legacy, and we believe the project is > now in full compliance with ASF policies. Therefore, we plan to replace the > DISCLAIMER_WIP with the standard DISCLAIMER in the next release (0.5.0), > but we will keep the DISCLAIMER_WIP for this 0.4.0 release. > > Regarding the tls_client-rs main.rs: > The code in tls_client-rs main.rs is based on a reference implementation > with modifications. The current comment is misleading, and we will update > it to: "This is a reference from Rustls example code." > We will include this update in the next release (0.5.0). > > If you have any additional comments, feel free to reply. Thanks again! > > > On 2025/02/19 07:17:19 Jean-Baptiste Onofré wrote: > > +0 (binding) > > > > I checked: > > - incubating is in the name/version > > - hash and checksum are OK > > - LICENSE should mention tls_client-rs main.rs is copied from > > > https://github.com/rustls/rustls/blob/v/0.21.0/examples/src/bin/simpleclient.rs > > - NOTICE is OK > > - DISCLAIMER_WIP contains "Releases may have incomplete licensing > > conditions.". Imho, it would be great to have more details to > > understand this statement. > > - ASF header is present in all expected files > > - no binary file found in the source distribution > > > > Regards > > JB > > > > On Wed, Feb 19, 2025 at 5:20 AM Yuan Zhuang <yu...@apache.org> wrote: > > > > > > Hi Community, > > > > > > I am pleased to be calling this vote for the release of > > > Apache Teaclave TrustZone SDK (incubating) 0.4.0 (release candidate 1). > > > > > > The vote from Apache Teaclave (incubating) community has PASSED with 5 > > > +1 votes (4 binding). > > > The vote thread is > > > https://lists.apache.org/thread/g1b3xlkoywp4kozcqb8oyxr52h7owkjq. > > > The result thread is > > > https://lists.apache.org/thread/9yxkcf6ogvllnb4obv9rlz3lfc4ot799. > > > > > > The release candidate to be voted over is available at: > > > - > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.4.0-rc.1/ > > > > > > The release note is available in: > > > - > https://github.com/apache/incubator-teaclave-trustzone-sdk/releases/tag/v0.4.0-rc1 > > > > > > The release candidate is signed with a GPG key available at: > > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS > > > Instructions to verify the source tar: > > > - > https://teaclave.apache.org/download/#verify-the-integrity-of-the-files > > > > > > Quick Building and Testing from source: > > > ``` > > > $ wget > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.4.0-rc.1/apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating.tar.gz > > > > > > $ tar zxvf apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating.tar.gz \ > > > && cd apache-teaclave-trustzone-sdk-0.4.0-rc.1-incubating > > > > > > # This will take about 30 minutes. Once everything is finished, we’ll > see > > > # the prompt: "+ popd /teaclave-trustzone-sdk/ci": > > > $ docker run --rm -it -v$(pwd):/teaclave-trustzone-sdk -w \ > > > /teaclave-trustzone-sdk yuanz0/teaclave-trustzone-sdk:ubuntu-24.04 \ > > > bash -c "./setup.sh && (./build_optee_libraries.sh optee) && source \ > > > environment && make && (cd ci && ./ci.sh)" > > > > > > ``` > > > > > > A release checklist for reference: > > > - > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > The vote will be open for at least 72 hours. Anyone can participate > > > in testing and voting, please feel free to try out the release > candidate > > > and provide your votes to this thread explicitly. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > > > > Best, > > > > > > Yuan Zhuang > > > Apache Teaclave (incubating) PPMC > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
