Hi Te Wang, Sorry for the late reply, I was travelling during the weekend and yesterday.
Yes, the LICENSE file should mention any file containing code coming from other projects. So, I agree with your change on the LICENSE file about Maven Wrapper and Spring Boot. I would also mention PathMap.js which is a copy from Snap.svg. When you update the LICENSE documenting dependencies, if the dependencies are using ALv2, and if the dependencies provide a NOTICE file, then it should be included in your NOTICE file. This is not strictly required if the dependency is a ASF project if you use "This product includes software developed at The Apache Software Foundation (http://www.apache.org/)". Let me know if you need my help on this. Thanks ! Regards JB On Sat, Feb 8, 2025 at 3:57 AM Te Wang <yi...@apache.org> wrote: > > Thank for you review, JB > > I have carefully checked the problem you mentioned and need to fix it. I have > proposed a solution for some of the problems. Please help me check whether it > is correct. > > - mvnw and mvnw.cmd should be mentioned in LICENSE as it's a copy from Maven > - ExtendedWhitespaceThrowableProxyConverter > > I checked and found that the mvnw and > ExtendedWhitespaceThrowableProxyConverter related files. I understand that I > need to add the following instructions to the LICENSE file. > > - - - - - > This project includes the Maven Wrapper (mvnw and mvnw.cmd), which is > distributed under the Apache License 2.0 For more details, see: > https://www.apache.org/licenses/LICENSE-2.0 > This project includes code from the Spring Boot project, which is licensed > under the Apache License 2.0. For more details, see: > https://www.apache.org/licenses/LICENSE-2.0 > - > org.apache.seata.server.logging.logback.ExtendedWhitespaceThrowableProxyConverter > > - - - - - > > Is this correct? > > > - NOTICE should be updated to include Snap.svg NOTICE > > yes, i will add Snap.svg to NOTICE > > Warm regards, > Te Wang > > On 2025/02/06 15:59:57 Jean-Baptiste Onofré wrote: > > +0 (binding) > > > > I checked: > > - incubating is in the name/version > > - hash and checksum are good > > - DISCLAIMER is present > > - LICENSE (source distribution) is not fully correct imho: > > - mvnw and mvnw.cmd should be mentioned in LICENSE as it's a copy > > from Maven > > - ExtendedWhitespaceThrowableProxyConverter should be mentioned > > in LICENSE as it is copied from spring-boot (ALv2) (no need to update > > NOTICE as spring-boot doesn't provide NOTICE) > > - PathMap.js should be mentioned in LICENSE as it is copied from > > adobe-webplatform Snap.svg (ALv2) (and NOTICE should be updated with > > Snap.svg NOTICE) > > - NOTICE should be updated to include Snap.svg NOTICE > > - A few binary artifacts found in the source distribution but > > acceptable (images in the designer module) > > - ASF header present in all expected files > > > > Regards > > JB > > > > On Thu, Feb 6, 2025 at 5:39 AM yixia <yi...@apache.org> wrote: > > > > > > Hello, > > > > > > This is a call for vote to release Apache Seata(incubating) 2.3.0-RC3. > > > > > > > > > The vote thread: > > > > > > https://lists.apache.org/thread/xcmzqfq61jdfz35z9fyhg609vkn0v602 > > > > > > > > > Vote Result: > > > > > > https://lists.apache.org/thread/xjjhfgjxfr01y2vqnsn9zldr193wqh3w > > > > > > > > > The release candidates: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.3.0-RC3/ > > > > > > > > > The staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapacheseata-1136/ > > > > > > > > > Git tag for the release: > > > > > > https://github.com/apache/incubator-seata/releases/tag/v2.3.0 > > > > > > > > > Git commit id for the release: > > > > > > https://github.com/apache/incubator-seata/commit/95ba284055beb0ee820f > > > > > > > > > Release Notes: > > > > > > https://github.com/apache/incubator-seata/releases/tag/v2.3.0 > > > > > > > > > The artifacts have been signed with Key [ 7ACD1A52F5AEF76A ], > > > corresponding > > > to[ yi...@apache.org ] > > > > > > which can be found in the keys file: > > > > > > https://downloads.apache.org/incubator/seata/KEYS > > > > > > > > > Build Environment: JDK 8+, Apache Maven 3.6.0+. > > > > > > - osx_aarch64： ./mvnw clean package -DskipTests=true -Parrch64 > > > > > > - osx-x86_64/other: ./mvnw clean package -DskipTests=true > > > > > > > > > CI Test Workflow: > > > > > > https://github.com/apache/incubator-seata/actions/runs/12882164154/job/35920458232 > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and signatures. > > > > > > [ ] LICENSE/NOTICE files exist > > > > > > [ ] No unexpected binary files > > > > > > [ ] All source files have ASF headers > > > > > > [ ] Can compile from source > > > > > > > > > To learn more about Apache Seata , please see https://seata.apache.org/ > > > > > > > > > Warm regards, > > > > > > Te Wang > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
