Hi Jean-Baptiste Onofré,

Thanks a lot for reviewing the Seata 2.3.0-RC3 release. Good catch on
these issues!

Jean-Baptiste Onofré <j...@nanthrax.net> 于2025年2月7日周五 00:01写道:
>
> +0 (binding)
>
> I checked:
> - incubating is in the name/version
> - hash and checksum are good
> - DISCLAIMER is present
> - LICENSE (source distribution) is not fully correct imho:
>      - mvnw and mvnw.cmd should be mentioned in LICENSE as it's a copy
> from Maven
>      - ExtendedWhitespaceThrowableProxyConverter should be mentioned
> in LICENSE as it is copied from spring-boot (ALv2) (no need to update
> NOTICE as spring-boot doesn't provide NOTICE)
>      - PathMap.js should be mentioned in LICENSE as it is copied from
> adobe-webplatform Snap.svg (ALv2) (and NOTICE should be updated with
> Snap.svg NOTICE)
> - NOTICE should be updated to include Snap.svg NOTICE

We’ve checked all the License and Notice issues mentioned above, and
we're already working on fixing them.

> - A few binary artifacts found in the source distribution but
> acceptable (images in the designer module)

If changes are needed here, do you have any better suggestions? Do we
really have to remove the image binary? Seata provides a drag-and-drop
designer here, and this designer has some image elements.

> - ASF header present in all expected files
>
> Regards
> JB
>
> On Thu, Feb 6, 2025 at 5:39 AM yixia <yi...@apache.org> wrote:
> >
> > Hello,
> >
> > This is a call for vote to release Apache Seata(incubating) 2.3.0-RC3.
> >
> >
> > The vote thread:
> >
> > https://lists.apache.org/thread/xcmzqfq61jdfz35z9fyhg609vkn0v602
> >
> >
> > Vote Result:
> >
> > https://lists.apache.org/thread/xjjhfgjxfr01y2vqnsn9zldr193wqh3w
> >
> >
> > The release candidates:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.3.0-RC3/
> >
> >
> > The staging repo:
> >
> > https://repository.apache.org/content/repositories/orgapacheseata-1136/
> >
> >
> > Git tag for the release:
> >
> > https://github.com/apache/incubator-seata/releases/tag/v2.3.0
> >
> >
> > Git commit id for the release:
> >
> > https://github.com/apache/incubator-seata/commit/95ba284055beb0ee820f
> >
> >
> > Release Notes:
> >
> > https://github.com/apache/incubator-seata/releases/tag/v2.3.0
> >
> >
> > The artifacts have been signed with Key [ 7ACD1A52F5AEF76A ], corresponding
> > to[ yi...@apache.org ]
> >
> > which can be found in the keys file:
> >
> > https://downloads.apache.org/incubator/seata/KEYS
> >
> >
> > Build Environment: JDK 8+, Apache Maven 3.6.0+.
> >
> > - osx_aarch64: ./mvnw clean package -DskipTests=true -Parrch64
> >
> > - osx-x86_64/other: ./mvnw clean package -DskipTests=true
> >
> >
> > CI Test Workflow:
> >
> > https://github.com/apache/incubator-seata/actions/runs/12882164154/job/35920458232
> >
> >
> > The vote will be open for at least 72 hours.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > Checklist for reference:
> >
> > [ ] Download links are valid.
> >
> > [ ] Checksums and signatures.
> >
> > [ ] LICENSE/NOTICE files exist
> >
> > [ ] No unexpected binary files
> >
> > [ ] All source files have ASF headers
> >
> > [ ] Can compile from source
> >
> >
> > To learn more about Apache Seata , please see https://seata.apache.org/
> >
> >
> > Warm regards,
> >
> > Te Wang
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to