Hi,

-1 (binding) form jmclean (IPMC)

I checked:
- incubating in name
- DISCLAIMER exists
- LICENSE is missing license information
- LICENSE is misisng info on [3][4]?
- NOTICE contains information on MIT/BSD license code when it should not
- How is this file is misisng a header [1]
- How is this file licensed? [2]
- No unexpected binary files
- I did not compile

For licenses like BSD and MIT the full text of teh license need to be included. 
It also unclear what project some 3rd party files belong to.

Kind Regards,
Justin

1.  ./scripts/generate-flatgeobuf.sh
2. ./baremaps-dem/src/test/resources/fuji.png
3. 
./baremaps-postgres/src/main/java/org/apache/baremaps/postgres/copy/CopyWriter.java
4. ./baremaps-flatgeobuf/src/main/fbs/header.fbs
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to