On Fri, Nov 15, 2024 at 5:21 AM PJ Fanning <fannin...@apache.org> wrote:
> Thanks Justin for the detailed analysis. > Checking LEGAL-469 [1], the only issue that seems to force an RC4, is > the CDDL/GPL licensed source file. > The MPL issue I raised is Category B. It's not listed in the LICENSE. It's a blocker. The legal ticket doesn't categorize binaries in the source release, but those should likely be in one of the two blocking areas as well. We should get that clarified at some point, since it does mentioned compiled code, but doesn't mention other non-code binaries. John > > Legal-469 says: Blocker - must be fixed and and revote on > * 3rd party Category X or Category B bundled code licenses not listed in > LICENSE > > It appears that the KIE team is very anxious to get a release out. If > they concentrated on just this issue for an RC4 and got that released > - and then come back and try to make progress on the other items for > the follow-up release - would that be a path forward? > > [1] https://issues.apache.org/jira/browse/LEGAL-469 > > On Fri, 15 Nov 2024 at 02:56, <jus...@classsoftware.com> wrote: > > > > Hi, > > > > -1 (binding) jmclean (IPMC) > > > > Looking at your release, it is hard to see at a glance what source > releases are. It would be best to clearly name these or, better still, put > all the binary releases into a subfolder. Is > apache-kie-10.0.0-incubating-sources.zip the only source release? > > > > For apache-kie-10.0.0-incubating-sources.zip I checked: > > - incubating in name > > - signatures and hashes are correct > > - LICENSE and NOTICE are not correct > > - DISCLAIMER exists > > - issues with ASF headers > > - no unexpected binary files > > - I didn’t try to compile - having some obvious instruction on how to do > this would be good to include > > > > Your NOTICE file is incorrect and looks to contain LICENSE information > this should go in your LICENSE file. The NOTICE is also not a place to list > the copyright statements of all included software, the NOTICE file should > only include re-located copyright statements and contents of included > software NOTICE files. Please see [1] > > > > The LICENSE is misisng information about bundled 3rd party files e.g > [2][3][4][5][6][10][11] and many other 3rd party files. > > > > Files like [3][6[9] seem to incorrectly have an ASF header on them when > the copyright belongs to someone else. How are these file licensed? > > > > Minified code should, if possible, be kept out of a source release. > [8][9] > > > > This file is GPL or CDDL licensed and shouldn't be included in an ASF > release. [11] > > > > I suggest you ask your mentor to help construct the LICENSE and NOTICE > file for your release. > > > > Kind Regards, > > Justin > > > > 1. https://infra.apache.org/licensing-howto.html > > 2. > ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/third_party/errai/src/main/java/org/jboss/errai/common/client/util/Base64Util.java > > 3. > ./incubator-kie-drools/drools-decisiontables/src/main/java/org/drools/decisiontable/parser/csv/CsvLineParser.java > > 4. > ./incubator-kie-drools/kie-dmn/kie-dmn-ruleset2dmn-parent/kie-dmn-ruleset2dmn/src/test/resources/wifi.pmml > (and other similar files) > > 5. > ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/lienzo-core/src/main/java/com/ait/lienzo/client/core/event/OrientationChangeHandler.java > (and many other files) > > 6 > ./incubator-kie-drools/kie-pmml-trusty/kie-pmml-models/kie-pmml-models-mining/kie-pmml-models-mining-tests/src/main/resources/randomforestclassifiermining/RandomForestClassifier.pmml > > 7. > ./incubator-kie-tools/packages/stunner-editors/lienzo-webapp/src/main/java/org/kie/lienzo/client/LienzoExamples.native.js > > 8. > ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/jspdf.min.js.back > > 9. > ./incubator-kie-kogito-apps/jitexecutor/jitexecutor-dmn/src/main/resources/META-INF/resources/bundle.js > > 10 > ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/canvas2svg.js.back > > 11. > ./incubator-kie-tools/packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/compat/javax/annotation/processing/Generated.java > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
