Hi PJ, Thank you for the further explanation.
The vote is uncalled. Let's continue to review this release candidate. We will continue to improve the NOTICE file content with the GitHub issue[1]. [1] https://github.com/apache/amoro-shade/issues/7 Best, Jinsong On Thu, Jul 25, 2024 at 6:40 PM PJ Fanning <fannin...@apache.org> wrote: > I didn't vote against the release and I'm happy not to block the release > over this. > We can continue the discussion about the Amoro shade jars in GitHub. If my > query about this is the only reason the vote was cancelled, maybe you could > uncancel the vote and proceed with trying to release as is. > > > On 2024/07/25 05:33:41 Justin Mclean wrote: > > Hi, > > > > There is probabkly a few way to deal with this. I’m not sure the > existing NOTICE is actually incorrect - i.e. the artefact was delevloped at > the ASF and as a whole that is copyright the ASF, but I coudl also see > people thinking that it means it contains ASF code. > > > > Kind Regards, > > Justin > > > > > > > On 23 Jul 2024, at 8:04 pm, PJ Fanning <fannin...@apache.org> wrote: > > > > > > I'm not sure the NOTICE files in your shade jars are correct. > > > > > > This is a snippet from your > amoro-shade-jackson-2-2.14.2-0.7.0-incubating.jar > > > ---- > > > Apache Amoro-shade > > > Copyright 2006-2024 The Apache Software Foundation > > > > > > This product includes software developed at > > > The Apache Software Foundation (http://www.apache.org/). > > > > > > amoro-shade-jackson-2 > > > Copyright 2024 The Apache Software Foundation > > > > > > This project includes software developed at > > > The Apache Software Foundation (http://www.apache.org/). > > > ---- > > > > > > This jar appears to have no code developed by the Apache Software > Foundation. It appears to only contain shaded classes from non-ASF projects > - specifically Jackson and Snakeyaml. > > > > > > > > > > > > On 2024/07/22 07:20:21 Xavier Bai wrote: > > >> +1, I deployed it in our environment and looks good. > > >> > > >> Jinsong Zhou <jinsongz...@apache.org> 于2024年7月22日周一 14:39写道： > > >> > > >>> Hello Incubator PMC, > > >>> > > >>> The Apache Amoro community has voted and approved the release of > Apache > > >>> Amoro(incubating) 0.7.0-incubating rc2. > > >>> We now kindly request the IPMC members review and vote for this > release. > > >>> > > >>> Apache Amoro (incubating) is a Lakehouse management system built on > open > > >>> data lake formats. > > >>> > > >>> Amoro community vote thread: > > >>> https://lists.apache.org/thread/cnjq4vll060qx98r2rzcjk6jn25fhv38 > > >>> > > >>> Vote result thread: > > >>> https://lists.apache.org/thread/9b8n0p2n19ovrdlcqxfhy83wxgg9pwyv > > >>> > > >>> The official Apache source release to be deployed to dist.apache.org > : > > >>> > > >>> > https://dist.apache.org/repos/dist/dev/incubator/amoro/0.7.0-incubating-RC2/ > > >>> > > >>> This source release has been signed with a PGP available here > (Apache ID: > > >>> jinsongzhou): > > >>> https://downloads.apache.org/incubator/amoro/KEYS > > >>> > > >>> All artifacts to be deployed to the Maven Central Repository: > > >>> > https://repository.apache.org/content/repositories/orgapacheamoro-1065 > > >>> > https://repository.apache.org/content/repositories/orgapacheamoro-1064 > > >>> > > >>> Git branch for the release: > > >>> https://github.com/apache/amoro/tree/v0.7.0-rc2 > > >>> https://github.com/apache/amoro-shade/tree/v0.7.0-rc2 > > >>> > > >>> Please download, verify, and test. > > >>> > > >>> The VOTE will pass after 3 binding approve. > > >>> > > >>> [ ] +1 approve > > >>> [ ] +0 no opinion > > >>> [ ] -1 disapprove with the reason > > >>> > > >>> To learn more about Apache Amoro, please see > https://amoro.apache.org/ > > >>> > > >>> Checklist for reference: > > >>> > > >>> [ ] Download links are valid. > > >>> [ ] Checksums and signatures. > > >>> [ ] LICENSE/NOTICE files exist > > >>> [ ] No unexpected binary files > > >>> [ ] All source files have ASF headers > > >>> [ ] Can compile from source > > >>> > > >>> Best, > > >>> Jingsong > > >>> > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
