Thank PJ for the review and suggestions. The vote is canceled and I will create another one after this issue is resolved.
I have created an issue[1] to track the NOTICE file problem. I tried to fix this issue with this PR[2], after this PR, the content of the NOTICE file should be: ---- Apache Amoro-shade (incubating) Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). amoro-shade-jackson-2 Copyright 2024 The Apache Software Foundation This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - com.fasterxml.jackson.core:jackson-annotations:2.14.2 - com.fasterxml.jackson.core:jackson-core:2.14.2 - com.fasterxml.jackson.core:jackson-databind:2.14.2 - com.fasterxml.jackson.dataformat:jackson-dataformat-csv:2.14.2 - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.2 - com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.14.2 - com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.14.2 - org.yaml:snakeyaml:1.33 ---- Please help to review if the PR fixes this issue. [1] https://github.com/apache/amoro-shade/issues/7 [2] https://github.com/apache/amoro-shade/pull/8 Best, Jinsong On Tue, Jul 23, 2024 at 6:07 PM PJ Fanning <fannin...@apache.org> wrote: > I'm not sure the NOTICE files in your shade jars are correct. > > This is a snippet from your > amoro-shade-jackson-2-2.14.2-0.7.0-incubating.jar > ---- > Apache Amoro-shade > Copyright 2006-2024 The Apache Software Foundation > > This product includes software developed at > The Apache Software Foundation (http://www.apache.org/). > > amoro-shade-jackson-2 > Copyright 2024 The Apache Software Foundation > > This project includes software developed at > The Apache Software Foundation (http://www.apache.org/). > ---- > > This jar appears to have no code developed by the Apache Software > Foundation. It appears to only contain shaded classes from non-ASF projects > - specifically Jackson and Snakeyaml. > > > > On 2024/07/22 07:20:21 Xavier Bai wrote: > > +1, I deployed it in our environment and looks good. > > > > Jinsong Zhou <jinsongz...@apache.org> 于2024年7月22日周一 14:39写道： > > > > > Hello Incubator PMC, > > > > > > The Apache Amoro community has voted and approved the release of Apache > > > Amoro(incubating) 0.7.0-incubating rc2. > > > We now kindly request the IPMC members review and vote for this > release. > > > > > > Apache Amoro (incubating) is a Lakehouse management system built on > open > > > data lake formats. > > > > > > Amoro community vote thread: > > > https://lists.apache.org/thread/cnjq4vll060qx98r2rzcjk6jn25fhv38 > > > > > > Vote result thread: > > > https://lists.apache.org/thread/9b8n0p2n19ovrdlcqxfhy83wxgg9pwyv > > > > > > The official Apache source release to be deployed to dist.apache.org: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/amoro/0.7.0-incubating-RC2/ > > > > > > This source release has been signed with a PGP available here (Apache > ID: > > > jinsongzhou): > > > https://downloads.apache.org/incubator/amoro/KEYS > > > > > > All artifacts to be deployed to the Maven Central Repository: > > > https://repository.apache.org/content/repositories/orgapacheamoro-1065 > > > https://repository.apache.org/content/repositories/orgapacheamoro-1064 > > > > > > Git branch for the release: > > > https://github.com/apache/amoro/tree/v0.7.0-rc2 > > > https://github.com/apache/amoro-shade/tree/v0.7.0-rc2 > > > > > > Please download, verify, and test. > > > > > > The VOTE will pass after 3 binding approve. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about Apache Amoro, please see https://amoro.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] All source files have ASF headers > > > [ ] Can compile from source > > > > > > Best, > > > Jingsong > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
