Hi Justin, Thanks for helping review this release.
The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was written by me before we open-sourced Fury and I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy serialization in Ray. I think it's OK to include it here since both are written by me. For files [1][2][3][4], could you give more details how those files include code from OpenSumi. The OpenSumi core developer bytemain[9] does commit some code to Fury, see his commits[10]. But I talked to him offline, he said he didn't copy code from OpenSumi. For Fury ArrayAsList, could you give more details how this class is copied from somewhere? It's just a simple wrapper for java object arrays. Fury just implements some basic interfaces of java Collection. I don't think we can write this class in another way without following the Java Collection interface. To reduce confusion, I removed some methods which don't get invoked in PR[11]. But as tison said, this may not resolve your concerns. For the benchmark issue, thanks for pointing this out. We excluded the benchmark directory in the source release, but didn't remove license reference from LICENSE file. I'll fix this later. 1. /javascript/packages/fury/lib/gen/datetime.ts 2. /javascript/packages/fury/lib/gen/index.ts 3. /javascript/packages/fury/lib/fury.ts 4. /javascript/packages/fury/lib/classResolver.ts 5. /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java 6. /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java 7. /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java 8. https://github.com/ray-project/ray/pull/21256 9. https://github.com/bytemain 10. https://github.com/apache/incubator-fury/commits?author=bytemain 11. https://github.com/apache/incubator-fury/pull/1560 On Wed, Apr 24, 2024 at 11:40 AM Justin Mclean <jus...@classsoftware.com> wrote: > HI, > > Sorry, it’s -1 (binding) from me as it looks like there is additional > third-party code without correct headers or mentioned in LICENSE. > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE has some issues (see below) > - NOTICE is fine > - It looks like some 3rd party code incorrectly has ASF headers (see below) > - All source files have ASF headers > > For the LICENSE file: > - there are several references to a benchmark directory, but it is not > included in the release > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] > - there seems to be code from Ray here [5][6] > - this file may have been copied from somewhere [7] > > Kind Regards, > Justin > > 1. /javascript/packages/fury/lib/gen/datetime.ts > 2. /javascript/packages/fury/lib/gen/index.ts > 3. /javascript/packages/fury/lib/fury.ts > 4. /javascript/packages/fury/lib/classResolver.ts > 5. > /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java > 6. > /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java > 7. > /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
