Hi Justin, Thanks for verifying potential compliance issue.
For 1-6 that you specify certain possible origins, do you have a report of the overlap files? I try to search the content of datetime.ts in OpenSumi but fail to find a result: https://github.com/search?q=repo:opensumi/core%20DateSerializerGenerator&type=code Also cc @chaokunyang and @weipeng if you're sure they're originally copied from elsewhere. For 7, the class seems no more than a thin wrapper of ArrayList that can be written by any Java developer. The file author confirmed that it was written by himself independently. Although Fury committers open [1] to make some changes, I don't think it can resolve any issue in your description if exist. [1] https://github.com/apache/incubator-fury/pull/1560 Best, tison. Justin Mclean <jus...@classsoftware.com> 于2024年4月24日周三 11:40写道： > HI, > > Sorry, it’s -1 (binding) from me as it looks like there is additional > third-party code without correct headers or mentioned in LICENSE. > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE has some issues (see below) > - NOTICE is fine > - It looks like some 3rd party code incorrectly has ASF headers (see below) > - All source files have ASF headers > > For the LICENSE file: > - there are several references to a benchmark directory, but it is not > included in the release > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] > - there seems to be code from Ray here [5][6] > - this file may have been copied from somewhere [7] > > Kind Regards, > Justin > > 1. /javascript/packages/fury/lib/gen/datetime.ts > 2. /javascript/packages/fury/lib/gen/index.ts > 3. /javascript/packages/fury/lib/fury.ts > 4. /javascript/packages/fury/lib/classResolver.ts > 5. > /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java > 6. > /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java > 7. > /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
