Here's my +1 on the code There's a few notes: - I would recommend the podling add some kind of reference to this clause in their NOTICE file: Copyright 2022 The Applied Research Laboratory for Intelligence and Security (ARLIS) (see [1]) - There's many files missing any headers. I think it's safe to assume they follow the same license since there is a LICENSE file at the root. I couldn't find any evidence that the files missing headers were copy/pasted from other repositories. - For files like the .ipynb files, I don't think there's a way to explicitly add a license header (since they're JSON files). You may want to consult with legal on how to add license file references for them.
[1]: https://github.com/UMD-ARLIS/incubator-flagon-distill/blob/distill_toolkit_refactor/NOTICE On Fri, Sep 16, 2022 at 11:12 AM John D. Ament <johndam...@apache.org> wrote: > Hey Josh, > > Thanks for the clarification, I found the thread from Craig. For future > reference, you shouldn't be voting on accepting a CCLA and/or SGA. > Procedure wise, this doesn't make sense. You're voting on accepting a code > donation, and it's just that code donations from the foundation's > standpoint require a SGA. The vote to accept the donation happens on the > podling's private list. I think we're in alignment up to that point (other > than the fact that the vote on the private list looks a bit off). > > To be 100% clear on the scope, you're looking for a third vote to view the > repo at [1] and confirm whether or not the content within is compliant to > be imported into a repository hosted by the ASF? Where I'm concerned with > the original vote, you're including in scope adding 5 new committers (which > aren't named in the vote thread) to the project. It's not apparent that > both are in scope, the vote to add committers should be separate from the > vote to add code to the repository (usually you would import the code > first, then vote to add the committers to the project). Do keep in mind > since these are your coworkers you're not building a diverse community of > committers. > > I'm including a few links to show a bit better how TLPs have handled this > before to give a little better picture. I'll take a deeper look in the > repo I linked in a bit, but I'm not seeing any major issues with the code. > > - John > > [1]: > https://github.com/UMD-ARLIS/incubator-flagon-distill/tree/distill_toolkit_refactor > TLPs: https://lists.apache.org/thread/r7jx0d2fy37kwj792n0qf5rcttyqzmzp , > https://lists.apache.org/thread/b2gmkbp879m72gdyztl674tqhtpdl7zn > > [1]: > https://github.com/UMD-ARLIS/incubator-flagon-distill/tree/distill_toolkit_refactor > > On Wed, Sep 14, 2022 at 5:52 PM Joshua C. Poore <poor...@apache.org> > wrote: > >> Hi John, >> >> Thanks for your response. >> >> I had a long thread with Calvin, Justin, and Craig Russell to clarify the >> process of onboarding new SW grants into existing podlings RE CCLA. The >> thread is on private@incubator, which I'm unable to grab a permalink for >> through lists... >> >> Bottom line up front: Suggestion was that formal votes through the >> incubator were not necessary in this case, but discussion and a vote on >> general level was encouraged to document consensus. >> >> Trying to adhere to good practice, but at this point a "consensus vote" >> on general is perfunctory. >> >> Respectfully, >> >> Josh (Flagon PPMC) >> >> On 2022/08/30 11:05:03 "John D. Ament" wrote: >> > Note that you're using public and private lists which is a big no-no. >> > >> > I'll be honest I don't understand what you're trying to get the IPMC to >> > vote on. You may need some help from mentors. I saw IP clearance and >> will >> > point out that [1] isn't for podlings. Likewise if this CCLA is new >> after >> > your proposal then likely [2] needs to be updated instead. After which >> your >> > mentors should be verifying the distribution rights. >> > >> > >> > [1]: https://incubator.apache.org/ip-clearance/index.html >> > [2]: https://incubator.apache.org/projects/flagon.html >> > >> > On Mon, Aug 29, 2022, 21:06 Joshua Poore <poor...@apache.org> wrote: >> > >> > > Hello General! >> > > >> > > Refreshing this 72 VOTE: >> > > >> > > I am looking for additional review and binding VOTEs from the >> Incubator >> > > regarding a recent SW grant (via CCLA) from UMD to the Flagon >> Podling. The >> > > Flagon community has VOTED to accept for reasons outlined below and >> > > Secretary has accepted the CCLA. We are seeking concurrence from the >> > > incubator. >> > > >> > > Details follow: >> > > >> > > > On Aug 19, 2022, at 9:32 PM, Joshua Poore <poor...@apache.org> >> wrote: >> > > > >> > > > Hello Incubator! >> > > > >> > > > I am continuing a 72 VOTE from the Flagon Community on Incubator >> General >> > > regarding the acceptance of an ICLA and Software Grant into the Apache >> > > Flagon (Incubating) Podling. >> > > > >> > > > The purpose of this VOTE is to establish consensus and transparency >> wrt >> > > to IP Clearance. >> > > > >> > > > We conducted a Community Discussion @ Flagon and a VOTE. >> > > > >> > > > VOTE Thread on Flagon Private: >> > > https://lists.apache.org/thread/t5gof3sj40xrv2ylrgntx6oz2vdcc37t >> > > > >> > > > VOTE Result on Flagon Private: >> > > https://lists.apache.org/thread/dvz7rtxl77pfqb3c3tgn36g1wbfgr54h >> > > > >> > > > [3] +1 (+2 Binding) >> > > > [0] 0 >> > > > [0] -1 >> > > > >> > > > Accepted Submission of ICLA to Secretary: >> > > https://lists.apache.org/thread/fz6v7x9gjcllr5dvsf5ho9hbt7ogrwvw >> > > > >> > > > >> > > > >> > > > Respectfully, >> > > > >> > > > Josh (Flagon PPMC) >> > > > >> > > > >> > > > Details on the Software Grant Follow (copied from original Flagon >> VOTE) >> > > below: >> > > > >> > > > >> > > > The Software Grant encompasses a refactor of the Apache Flagon >> Distill >> > > product, which has been deprecated for a few years now [1] >> > > >> > > > This Grant includes ~150 new commits and thousands of new insertions >> > > (and a lot of deletions) At UMD my team and I re-thought Distill as a >> > > Python Package (for distro through PyPI) [2] that allows users to: >> > > >> > > > - efficiently segment UserALE.js (or User Behavior Logs) data >> > > >> > > > - curate segments - transform segments with logical operations >> > > (intersection, union, etc.) >> > > >> > > > - filter log data extracted from segments >> > > >> > > > - apply analytics (e.g., statistical, graphs) to data extracted from >> > > segments >> > > >> > > > - support graph-based visualization (funnel, sankey) >> > > >> > > > Additionally: >> > > >> > > > - code is well documented [3] >> > > >> > > > - excellent working examples [4] >> > > >> > > > Distill also provides examples for dashboards to visualize segments >> > > using both Apache Superset and Plotly/Dash >> > > >> > > > The original Distill product was tethered to a front-end (Tap), >> relied >> > > on rudimentary (and error-prone) processing of segments within the >> client. >> > > This made Distill difficult to maintain and required users to adopt >> tap, >> > > limiting their analytical use-cases with UserALE.js and Distill. >> Overall, >> > > I think that Distill provides a far more scaleable product to engage >> (and >> > > expand) our development community. I think this will add real value to >> > > Apache Flagon. >> > > >> > > >> > > > Overhead/Actions prior to release: >> > > >> > > > - Documentation builds will need be adjusted for a new repo/branch >> > > >> > > > - Additional documentation for a few analytical functions (i.e., >> > > click-rate) >> > > >> > > > - Minor tweaks to simply code in a few functions (i.e., click-rate) >> > > >> > > > - Some restructuring of Repo to consolidate and organize examples >> > > >> > > > - a few additional README’s should be added (i.e., examples /dir) >> > > >> > > > IP Clearance The Software Grant is signed by Felicia Metz, esq. >> who is >> > > an Associate Director at the University of Maryland’s, UMD Ventures >> office, >> > > which has authority to release UMD IP. That makes accepting this grant >> > > significantly easier from an IP Clearance perspective. New >> Committers The >> > > UMD executed CCLA includes 5 new committers and potentially new PPMC >> > > members [see 5 for executed Software Grant from UMD] >> > > > >> > > > [1] https://github.com/apache/incubator-flagon-distill >> > > > [2] >> > > >> https://github.com/UMD-ARLIS/incubator-flagon-distill/tree/distill_toolkit_refactor >> > > > [3] >> > > >> https://incubator-flagon-distill.readthedocs.io/en/distill_toolkit_refactor >> > > > [4] >> > > >> https://github.com/UMD-ARLIS/incubator-flagon-distill/blob/distill_toolkit_refactor/examples/Segments_Demo.ipynb >> > > > [5] >> https://lists.apache.org/thread/fz6v7x9gjcllr5dvsf5ho9hbt7ogrwvw >> > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > >> > > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
