Hi, +1 (no binging)
I checked: - incubating in name - LICENSE seem to include software that is not bundled in the source release - NOTICE is fine - DISCLAIMER-WIP exists - no unexpected binary files - all ASF files have ASF headers Thanks, Xun Liu On Wed, Apr 14, 2021 at 2:54 PM Juan Pan <panj...@apache.org> wrote: > Hi, > > > +1 binding, Thanks for clarification. > > > > > [x] Download links are valid. > > [x] Checksums and PGP signatures are valid. > > [x] LICENSE, NOTICE and DISCLAIMER-WIP files are correct. > > [x] All files have license headers if necessary. > > > > > > ---------------------------------------------------------------- > Juan Pan (Trista) > > Senior DBA & PMC of Apache ShardingSphere > E-mail: panj...@apache.org > > > > > On 04/13/2021 15:15，Hans Van Akelyen<hans.van.akel...@gmail.com> wrote： > Hi Justin, > > Thanks for the thorough check, at compile time we have quite a lot of > category X licensed dependencies, most JDBC drivers are not category A/B, > all these dependencies are optional and need to be included by the user if > he wants to connect to this specific database. We also have Transient > category X dependencies from other projects (and raised at least one ticket > in another project and will continue to do so if we bump into more) > > Because of our large list of 3rd party dependencies either our own, or > transient dependencies from platforms we create connectors for I did a full > check and listed all dependencies that are included in the binary release > [1]. Currently this is maintained manually but we are looking at automating > the process and warn us when dependencies that are not allowed are added. > > The Exasol dependency and license will be removed in the next release, at > first glance it seemed it would be allowed. > > For the CC-BY issue, how does one remove it from a source release and > include it in a binary release if the binary release can only be created > from the sources you are releasing? > > Thanks, > Hans > > [1] ./assemblies/static/src/main/resources/THIRD-PARTY.txt > > > On Tue, 13 Apr 2021 at 06:01, Justin Mclean <jus...@classsoftware.com> > wrote: > > Hi, > > +1 (binding) because of DISCLAIMER-WIP > > I checked: > - incubating in name > - signature and hash s fine > - WIP disclaimer exists > - no unexpected binary files > - all source files have ASF headers > - can compile from source > > There some issues: > - Creative Commons Attribution-Share Alike 4.0 content can’t be included > in a source release in text form [1] > - Dependancy on a category X licensed code (see other email) > - Possible dependancies on [2][3][4] which look to be category X licenses. > here may be some more I had a quick skim through the rather large list of > dependancies. > > Thanks, > Just8in > > 1. https://www.apache.org/legal/resolved.html#cc-by > 2. mysql:mysql-connector-java:8.0.19 > 3. org.mariadb.jdbc:mariadb-java-client:2.5.1 > 4. org.json:json:20200518 > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > >
