Hi, +1 from me (binding).
I checked: - Incubating in name - DISCLAIMER-WIP exists - LICENSE is fine - NOTICE has incorrect year - No unexpected binary files - Checked PGP signatures - Checked checksums - Code compiles and tests successfully run PS: DISCLAIMER-WIP/LICENSE should be fixed as Justin mentioned. Kind Regards, Furkan KAMACI On Tue, Feb 9, 2021 at 8:15 PM Sam Skalicky <samskali...@apache.org> wrote: > Hi Mentors, > > Please help us get out this release by voting. Thanks for helping MXNet as > it grows in the incubator. > > Thanks! > Sam > > On 2021/02/01 18:52:24, Sam Skalicky <samskali...@apache.org> wrote: > > Thanks Justin, > > > > We'll take note of these callouts and address them in the next release. > > > > Sam > > > > On 2021/01/28 03:38:37, Justin Mclean <jus...@classsoftware.com> wrote: > > > Hi, > > > > > > +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not > correct and source release contains Category B licensed bits. > > > > > > I checked: > > > - incubating in name > > > - signatures and hashes are fine > > > - DISCLAIMER (WIP) exist but information has not been updated in it > > > - LICENSE looks OK but I’ve not checked everything and there looks > like there been a lot of changes since the last release. It missing some > 3rd party licenses. > > > - NOTICE has incorrect year > > > - The source include a font under the OFL license In general this > can't be included in a source release. [1] This should be mention in the > DISCLAIMER. Also [4] and [7] are under the OFL license I believe. > > > - It would be good to see more description in the rat exclusions file > (and have it at the top level) > > > - No unexpected binary files. However I did seem some binary files > that should be mentioned in LICENSE. [2][3][4][5][6][7] > > > - It also unclear how [2] is licensed and may be category X > > > - I didn’t try to compile from source > > > > > > Thanks, > > > Justin > > > > > > > > > 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses > > > 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont* > > > 3. ./3rdparty/mkldnn/doc/assets/fonts/lato* > > > 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf* > > > 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax* > > > 6. > ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/* > > > 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid* > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
