Which version of bazel you are using? Heron is using 0.26.1 current. Mac dev environment could be another possibility. XCode tool chain seems to have some changes causing some rules to fail and maybe the new MacOS has these changes by default. I have been using docker to build after installing the latest XCode.... Definitely something we should look into.
Thanks for the feedback! On Thu, Nov 14, 2019 at 7:19 AM Furkan KAMACI <furkankam...@gmail.com> wrote: > Hi, > > +1 from me. > > I checked: > - Incubating in name > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - Checked PGP signatures > - Checked Checksums > > PS 1: Justin's objections should be resolved. > > PS 2: I couldn't compile the source code at my MacOSX Catalina following > this tutorial: > https://apache.github.io/incubator-heron/docs/developers/compiling/mac/. > > Could you explain it whether there are checkstyle errors or more? Error is > below: > > ERROR: > > /private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl:130:19: > Traceback (most recent call last): > File > > "/private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl", > line 125 > rule(<3 more arguments>) > File > > "/private/var/tmp/_bazel_kamaci/625cc18c0e4b9bd1bb57e5abdd5a955a/external/com_google_protobuf/protobuf.bzl", > line 130, in rule > attr.label(cfg = "host", <3 more arguments>) > 'single_file' is no longer supported. use allow_single_file instead. You > can use --incompatible_disable_deprecated_attr_params=false to temporarily > disable this check. > ERROR: > > /Users/kamaci/incubator-heron-0.20.2-incubating-rc1/tools/java/src/org/apache/bazel/checkstyle/BUILD:36:1: > error loading package '@com_google_protobuf//': Extension file > 'protobuf.bzl' has errors and referenced by > '//tools/java/src/org/apache/bazel/checkstyle:util' > ERROR: Analysis of target '//heron/shell/assets:assets' failed; build > aborted: error loading package '@com_google_protobuf//': Extension file > 'protobuf.bzl' has errors > INFO: Elapsed time: 105.248s > INFO: 0 processes. > FAILED: Build did NOT complete successfully (142 packages loaded, 489 > targets configured) > > Kind Regards, > Furkan KAMACI > > On Thu, Nov 14, 2019 at 4:50 PM Josh Fischer <j...@joshfischer.io> wrote: > > > Hi all, > > > > We have one binding vote so far. Does anyone have the time to vote on > this > > release? > > > > - Josh > > > > On Sun, Nov 10, 2019 at 2:42 PM Justin Mclean <jus...@classsoftware.com> > > wrote: > > > > > Hi, > > > > > > +1 (binding) > > > > > > Thanks for fixing teh issues raised last time. > > > > > > I checked: > > > - incubating in name > > > - signatures and hashes are file > > > - DISCLAIMER exists > > > - LICENSE is OK. It would be god to see local links to the licenses as > > > URLs content may change or they may die over time. > > > - NOTICE is fine > > > - All source files have ASF headers where needed > > > - No unexpected binary files > > > - I didn’t try compiling > > > > > > For LICENSE: > > > - JQuery is incorrectly listed as ALv2 it’s MIT licensed > > > - JSXTransformer is also listed as ALv2 and is actually MIT licensed > > > > > > For all BSD and MIT you need to include the full text of the license. > It > > > seems you are missing some license(s) for file that don’t include the > > > header and are missing from the licenses directory e.g. > JSXTransformer. I > > > did not check them all. > > > > > > Thanks, > > > Justin > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > -- > > Sent from A Mobile Device > > >
