Thanks Justin. We will take note and address them in the next release.
- Josh On Sun, Nov 10, 2019 at 2:42 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > Thanks for fixing teh issues raised last time. > > I checked: > - incubating in name > - signatures and hashes are file > - DISCLAIMER exists > - LICENSE is OK. It would be god to see local links to the licenses as > URLs content may change or they may die over time. > - NOTICE is fine > - All source files have ASF headers where needed > - No unexpected binary files > - I didn’t try compiling > > For LICENSE: > - JQuery is incorrectly listed as ALv2 it’s MIT licensed > - JSXTransformer is also listed as ALv2 and is actually MIT licensed > > For all BSD and MIT you need to include the full text of the license. It > seems you are missing some license(s) for file that don’t include the > header and are missing from the licenses directory e.g. JSXTransformer. I > did not check them all. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
