Thanks Zach for jumping on this! Justin - Zach's follow up is in this PR into 1.4 branch [1 <https://github.com/apache/incubator-mxnet/pull/13856>], which includes all changes (another PR was already merged to master) Once you confirm changes look good, Steffen can restart the vote process.
Cheers, Hagay [1] - https://github.com/apache/incubator-mxnet/pull/13856 On Fri, Jan 11, 2019 at 3:42 PM Zach Kimberg <zachary.kimb...@gmail.com> wrote: > Hi Justin, > > We will replace the file CC-BY-SA documentation file with a pointer then. > Because it is a submodule, we can't change it in the code and will just > replace it as part of our release process. > > Per you suggestion, I also added copyright owners to the license file in > addition to fixing the various problems. Hopefully that makes it easier to > review. I think our license should be correct now. Can you help take a look > at our master branch ( > https://github.com/apache/incubator-mxnet/blob/master/LICENSE) to see if > there are any problems that I have missed before we continue with our 1.4 > release? > > Thanks, > Zach > > On Thu, Jan 10, 2019 at 1:27 AM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > > Hi Justin, it would be great if we can clarify the policy the submodule > > dependencies. > > > > Basically follow the guiding principle [1] what states anything that is > > bundled in a release need to be mentioned in LICENSE. If it not in the > > release then it doesn’t need to be included. > > > > Thanks, > > Justin > > > > 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
