Hi,

-1 binding as NOTICE should not contain copyrights of bundled 3rd party 
software. The NOTICE file needs to only contain what is required  (and not 
already in LICENSE) and needs to be as small as possible as it affects 
downstream projects. [2]

I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE is missing info for fonts [1]
- NOTICE is incorrect
- Some .sh files are missing ASF headers
- Can compile from source

Thanks,
Justin

1. 
apache-gobblin-incubating-sources-0.12.0/gobblin-admin/src/main/resources/static/fonts/*
2. http://www.apache.org/dev/licensing-howto.html#mod-notice



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to