Justin, On Thu, Feb 16, 2017 at 7:45 PM Justin Mclean <jus...@classsoftware.com> wrote:
> Hi, > > > - README points to "rocketmq community" as a github page > > Yes they are aware this is an issue. > > > - fastjson (missing NOTICE) > > Why is this an issue? Fastjson is mentioned in LICENSE and the 3rd party > repo contains no NOTICE file (which is rather common sadly). > This is what I see in fastjson's NOTICE file (its within the JAR) /* * Copyright 1999-2101 Alibaba Group. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ Note things like the broad copyright dates. However, knowing the relationship to rocketmq, may be good to reach out to get a valid NOTICE file put together. > > > - commons-cli (missing NOTICE) > > The commons cli doesn’t contain anything that needs to be propagated into > our NOTICE AFAICS. > > Yep agreed, I missed that point in http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > > - NOTICE points to non-existent file LICENSE.<component>.txt > > We missed that, but it is referring to dependancies that not are not > bundled. I’d suggest to fix we just remove that paragraph. > Agreed. > > > - LICENSE-BIN mentions “ASL2" > > This is because an Apache commons (probably incorrectly) project we bundle > has this in it’s NOTICE file. > > Any plans to reach out to get it corrected, or try to upgrade if they already fixed? > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
