On Thu, Feb 16, 2017 at 12:32 PM Bruce Snyder <bruce.sny...@gmail.com>
wrote:

> +1 (binding)
>
> No showstopper issues found, only minor issues that will be ironed out in
> subsequent releases (e.g., README needs some cleanup, need consistency in
> artifact naming).
>

Do you have a full list of those issues?  Here's problems I see
(non-exhaustive):

- README points to "rocketmq community" as a github page
- LICENSE/NOTICE are not consistent for the bin files. (there should be
more apache licensed stuff in the bin than actually present)
  - fastjson (missing NOTICE)
  - commons-cli (missing NOTICE)
  - NOTICE points to non-existent file LICENSE.<component>.txt
- LICENSE-BIN mentions "ASL2"

Assuming this is your list, I'm OK with a +1.

John



>
> Bruce
>
> On Wed, Feb 15, 2017 at 10:46 PM, yukon <yu...@apache.org> wrote:
>
> > Hello Incubator PMC,
> >
> > The Apache RocketMQ community has voted and approved the proposal to
> > release Apache RocketMQ 4.0.0 (incubating). We now kindly request the
> IPMC
> > review and vote on this incubator release.
> >
> > [VOTE] Thread:
> > https://lists.apache.org/thread.html/349e3268cf5ae7ec65d1cd584362c7
> > 6bd11f86afb935b2bfb8ee6b6b@%3Cdev.rocketmq.apache.org%3E
> >
> > [RESULT][VOTE] Thread:
> > https://lists.apache.org/thread.html/6487e8afc7a71cbdf9848d1270997e
> > c55ffe6cb9e7a2ddfce2bedb35@%3Cdev.rocketmq.apache.org%3E
> >
> > The RC3 artifacts:
> > https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> > 0.0-incubating-rc3/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-rocketmq/tree/
> > rocketmq-4.0.0-incubating
> >
> > Hash for the release tag:
> > dddc3daa2cbec4c7240d6525d2ce198826d29967
> >
> > Release Notes:
> > http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-
> > incubating/
> >
> > The artifacts have been signed with Key : E9BDDB0E, which can be found in
> > the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
> >
> > The maven release artifacts:
> >
> https://repository.apache.org/content/repositories/orgapacherocketmq-1003
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Here is my +1
> >
> > Thanks,
> > The Apache RocketMQ Team
> >
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
>
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ <http://bruceblog.org/>
> Twitter: http://twitter.com/brucesnyder
>

Reply via email to