+1 (binding) but with reservations about branding. Downloaded, checked hashes, built using Oracle JDK 1.8 and maven-3.2.1 on Ubuntu Linux, ran apache-rat.
I also re-read discussions about 0.2.0-RC2 [1] and 0.2.0-RC3 [2] releases. In README.md, the product is described as “Metron"; should be "Apache Metron (incubating)". Similarly NOTICE. Maybe I’m not up on current policy, but isn’t incubation supposed to be represented in the project’s maven GAV? I would have expected the version string to be “0.3.0-incubating”, but it is “0.3.0”. Can someone on the IPMC please clarify the requirements for version strings of incubating projects? While on the subject of branding, the project web page http://metron.incubator.apache.org/ <http://metron.incubator.apache.org/> should also refer to the project as “Apache Metron (incubating)”. The downloads should come from Apache, not GitHub. And the twitter home page https://twitter.com/apachemetron <https://twitter.com/apachemetron> should mention incubation. Given that this would be the fourth release under the incubator, I am surprised that the PPMC has not sorted out these branding issues yet. Now, back to the release. No need for DISCLAIMER or LICENSE in dist folder. (KEYS is fine. I see the point of having CHANGES in the dist folder, but it’s a bit unusual.) Checked that README.md has build instructions. It would be useful if the build instructions state the required JDK version (1.8, apparently). Julian [1] http://mail-archives.apache.org/mod_mbox/incubator-general/201607.mbox/%3ccc90a785-92a5-430b-9774-1c812bc12...@hortonworks.com%3E <http://mail-archives.apache.org/mod_mbox/incubator-general/201607.mbox/%3ccc90a785-92a5-430b-9774-1c812bc12...@hortonworks.com%3E> [2] http://mail-archives.apache.org/mod_mbox/incubator-general/201608.mbox/%3CCAF1jEfAP9SQ9WpzvcqgoOBo14W2K87sB2rVO=OPXx42fbZp+=g...@mail.gmail.com%3E <http://mail-archives.apache.org/mod_mbox/incubator-general/201608.mbox/%3CCAF1jEfAP9SQ9WpzvcqgoOBo14W2K87sB2rVO=OPXx42fbZp+=g...@mail.gmail.com%3E> > On Nov 23, 2016, at 9:48 AM, Stian Soiland-Reyes <st...@apache.org> wrote: > > My vote: +1 (binding) > > +1 git tag matches src (commit > 7aea4ba35d1a931d72898bffd9725be3075fe8ca) (except site/ and .git*) > +1 .asc signatures match, key in KEYS > +0 .sha/.md5 hashes correct - could these have more conventional > format and filenames? > -0 Vote email didn't reference hash values or dist.apache.org SVN > revision number (I assume r16997) > +0 No need for DISCLAIMER or LICENSE within dist folder > +1 apache- and -incubator in file/folder-name > +1 DISCLAIMER present in archive > +1 NOTICE present in archive with attributions (you don't need the > indentation) > +1 LICENSE present. (first newline missing, indentation wrong on first > line. Very long line in extension) > -0 STIX BSD license not included, URL is wrong. > +1 mvn apache-rat:check > -1 mvn install crashes my X server (!) (See below) > +1 No unexpected binaries (except test data, serialized from Hadoop?) > > > For the next release vote, could you include either the git commit ID > (not just tag) or the hash of the source archive? for archival > purposes? > > For the next release's LICENSE, download > http://www.apache.org/licenses/LICENSE-2.0.txt and add at the end your > extensions about the Stix project as you have already, except perhaps > wrap the long lines. > > For the next release, could you include the STIX license as it was at > the point of importing? A link like >> available under a BSD license. For details, see >> http://stix.mitre.org/about/termsofuse.html > > This is not enough long term as the license is not versioned and can > change later - in fact the URL already redirects to > http://stixproject.github.io/about/ which points to > http://stixproject.github.io/legal/ which points back to /about/ - and > so I can't find the actual STIX license to verify this. > > Add it as a file like licenses/STIX.LICENSE.txt and refer to that from > the top level LICENSE and the file headers. (don't remove the old > file headers, just augment) > > > My +1 vote assumes this STIX license is a BSD-3-clause or 2-Clause, if > it is a BSD-4 clause it is NOT open source or compatible and my vote > would be -1. > > > For the hashes I would have preferred the style: > > apache-metron-0.3.0-rc1-incubating.tar.gz.sha1 containing: > 080a54dd02cfe9fa91cd92305726443302ef250e > apache-metron-0.3.0-rc1-incubating.tar.gz > > apache-metron-0.3.0-rc1-incubating.tar.gz.md5 containing: > 1cc8ecfac074d5667845b835e28f6403 apache-metron-0.3.0-rc1-incubating.tar.gz > > ..or Maven-compatible without the spaces, filename or newline (no > spacing within the hash value) > > > (You may fix the hashes for this RC before you svn mv on dist) > > > > Below details about test failures only: > > > > The unit tests of metron-analytics/metron-maas-service crashes my X > server on Ubuntu 16.04 with Nvidia drivers..! Not sure why it would > touch X? > > It happens right after it says once "Found endpoint .... > biggieubuntu:someport" (my hostname). -- sorry it crashed a bit too > fast to check the port number! > > mvn clean install -DskipTests works though, so I won't fail this > particular vote. > > > I had a similar problem with mvn clean install within > > docker run -it maven:3-jdk-8 bash > > (which take a while in metron-maas-service) - that does a lot of > echo-endpoint things, but then fails with > > Found endpoints: dummy:1.0 @ http://c6ced9e36c5e:1500 serving: > apply=echo > Cleaning up... > Killing 1413 from 1413 ? 00:00:00 dummy_rest.sh > 2016-11-23 17:33:23,070 ERROR [Thread[Thread-615,5,main]] > delegation.AbstractDelegationTokenSecretManager > (AbstractDelegationTokenSecretManager.java:run(659)) - > ExpiredTokenRemover received java.lang.InterruptedException: sleep > interrupted > 2016-11-23 17:33:23,183 ERROR [Thread[Thread-595,5,main]] > delegation.AbstractDelegationTokenSecretManager > (AbstractDelegationTokenSecretManager.java:run(659)) - > ExpiredTokenRemover received java.lang.InterruptedException: sleep > interrupted > 2016-11-23 17:33:23,193 ERROR [Thread[Thread-591,5,main]] > delegation.AbstractDelegationTokenSecretManager > (AbstractDelegationTokenSecretManager.java:run(659)) - > ExpiredTokenRemover received java.lang.InterruptedException: sleep > interrupted > 2016-11-23 17:33:38,159 ERROR [Curator-TreeCache-1] > curator.ConnectionState (ConnectionState.java:checkTimeouts(200)) - > Connection timed out for connection string (127.0.0.1:46611) and > timeout (15000) / elapsed (15003) > org.apache.curator.CuratorConnectionLossException: KeeperErrorCode = > ConnectionLoss > at org.apache.curator.ConnectionState.checkTimeouts(ConnectionState.java:197) > at org.apache.curator.ConnectionState.getZooKeeper(ConnectionState.java:87) > > and fails tests like > > at > org.apache.metron.maas.service.MaasIntegrationTest.testDSShell(MaasIntegrationTest.java:287) > > > Tested with: > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T16:41:47+00:00) > Maven home: /home/stain/software/maven > Java version: 1.8.0_111, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-47-generic", arch: "amd64", family: "unix" > > On 17 November 2016 at 19:45, Casey Stella <ceste...@gmail.com> wrote: >> This is a call to vote on releasing Apache Metron 0.3.0-RC1 incubating >> >> >> Full list of changes in this release: >> >> https://dist.apache.org/repos/dist/dev/incubator/metron/0.3. >> 0-RC1-incubating/CHANGES >> >> >> The tag/commit to be voted upon is apache-metron-0.3.0-rc1-incubating: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-metron. >> git;a=shortlog;h=refs/tags/apache-metron-0.3.0-rc1-incubating >> >> The source archive being voted upon can be found here: >> >> https://dist.apache.org/repos/dist/dev/incubator/metron/0.3. >> 0-RC1-incubating/apache-metron-0.3.0-rc1-incubating.tar.gz >> >> Other release files, signatures and digests can be found here: >> >> https://dist.apache.org/repos/dist/dev/incubator/metron/0.3. >> 0-RC1-incubating/ >> >> The release artifacts are signed with the following key: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-metron. >> git;a=blob;f=KEYS;h=8381e96d64c249a0c1b489bc0c234d9c260ba55e;hb=refs/tags/ >> apache-metron-0.3.0-rc1-incubating >> >> >> Please vote on releasing this package as Apache Metron 0.3.0-RC1 incubating >> >> >> When voting, please list the actions taken to verify the release. >> >> Recommended build validation and verification instructions are posted here: >> >> https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds >> >> >> This vote will be open for at least 72 hours. >> >> >> [ ] +1 Release this package as Apache Metron 0.3.0-RC1 incubating >> >> [ ] 0 No opinion >> >> [ ] -1 Do not release this package because... > > > > -- > Stian Soiland-Reyes > http://orcid.org/0000-0001-9842-9718 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
