Hi, +1 (binding). Nice work on the LICENSE.
I checked: - signature and hashes correct - release name contain incubating - DISCLAIMER exits - LICENSE file has some minor issues (see below) - NOTICE good - unable to compile on OS X (but notes say it only has experiment support) Minor issues LICENSE file: - BSD for Async HBase has "Google Inc.” in the 3rd clause probably a copy and paste error? - Path to WebRTC licensed files should include src/kudu/util/random.h - Missing license in LICENSE for FindGMock [1] - Possible incorrect Apache header on BSD license in file [2]? Should also be in LICENSE. - Header with copyright Cloudera which should be ASF? [3] - Short form i.e. pointers to license file are preferred. There is possibly a more serious issue with the licensing of this file [4]. See also [5][6]. From inside the file: "Permission to make digital or hard copies of all or part of this work for personal or classroom use is granted without fee provided that copies are not made or distributed for profit or commercial advantage and that copies bear this notice and the full citation on the first page. To copy otherwise, to republish, to post on servers or to redistribute to lists, requires prior specific permission and/or a fee.” May be serious enough for another RC? IMO Up to the RM/PMC to decide that or fix in the next incubating release. A few other minor things: - NOTICE file file line should probably be "Apache Kudu (incubating)" rather than "Apache Kudu” - There’s another github mirror here https://github.com/cloudera/kudu - does anyone else think that a little odd? JFYI The OSX compile error was (after about 1/2 hour of compiling things): + make -j8 install CDPATH="${ZSH_VERSION+.}:" && cd . && aclocal-1.14 -I m4 /bin/sh: aclocal-1.14: command not found make: *** [aclocal.m4] Error 127 Thanks, Justin 1. ./apache-kudu-incubating-0.7.0/cmake_modules/FindGMock.cmake 2. ./apache-kudu-incubating-0.7.0/cmake_modules/FindProtobuf.cmake 3. ./apache-kudu-incubating-0.7.0/python/Makefile 4. ./apache-kudu-incubating-0.7.0/docs/whitepaper/vldb.cls 5. http://www.acm.org/sigs/publications/sig-alternate-v1.1 6. http://www.acm.org/publications/copyright-statement --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
