tbh, I've never found that licensing how-to document terribly clear - i feel like i get a different read of it every time i go through it. maybe it's just me.
anyway, I've read it again, in the context of what you've said here, and it seems like we should not have included the Apache licensed dependencies in the binary LICENSE file, so that has been removed: https://github.com/apache/incubator-tinkerpop/blob/6e08d186850457bab4e15ddf603f50fd16728f41/gremlin-console/src/main/LICENSE https://github.com/apache/incubator-tinkerpop/blob/6e08d186850457bab4e15ddf603f50fd16728f41/gremlin-server/src/main/LICENSE I didn't change the binary NOTICE files as I believe that their contents are just Apache licensed stuff that themselves have NOTICE so given [1] I think I have this right. I also adjusted the source LICENSE/NOTICE given your recent feedback on Activiti: https://github.com/apache/incubator-tinkerpop/blob/6e08d186850457bab4e15ddf603f50fd16728f41/LICENSE https://github.com/apache/incubator-tinkerpop/blob/6e08d186850457bab4e15ddf603f50fd16728f41/NOTICE how's that looking? 1. http://www.apache.org/dev/licensing-howto.html#mod-notice On Sun, Nov 22, 2015 at 2:36 AM, Justin Mclean <jus...@classsoftware.com> wrote: > HI, > > > Maybe we did something wrong here, but those classes are here: > > > > > https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriterHelper.java > > > > The are basically just recreated as inner classes in that java file. > > Nothing "wrong" as they are Apache licensed however you may need to change > NOTICE as described in the previous mail. > > > The link you posted was for 3.0.0-incubating, > > Yes that where the issue was originally brought up and it’s not been > corrected in this release. > > > I something amiss in our current version that you still see wrong > somehow? > > Yes the LICENSE and NOTICE are not correct in the binary files, most of > what what's in NOTICE should be in LICENSE or not included at all. The > assembling license and notice page spells it out quite clearly [1]. In > particular look at the section on adding permissive software and what > doesn’t go in NOTICE. > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
