Hi Justin,
Being part of the maven archetype, these are the templates to
"quickstart" a user with a project using brooklyn. Such projects would
not be licensed to the ASF, but we could also say that it's then their
business to update the copyright header. I am kinda neutral on this one,
but I guess this would be the explanation for the missing headers.
Cheers,
Hadrian
On 07/22/2015 10:08 AM, Justin Mclean wrote:
Hi,
+1 binding
I checked the source release.
- release contains incubating
- signatures and hashed good
- DISCLAIMER exists
- LICENSE and NOTICE good (a few minor issues)
- no unexpected binary files
- some source files are missing headers (see
/usage/archetypes/quickstart/src/brooklyn-sample/src/test/java/com/acme/sample/brooklyn/sample/app/*.java)
- can compile from source
Minor issues:
- LICENCE is missing standard appendix
- probably no need for the full text of MIT and BSD as the short version is
preferred and already used
- LICENSE is missing:
riak (see
./software/nosql/src/main/resources/brooklyn/entity/nosql/riak/vm.args + others)
normalize.css (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/css/mobile-angular-ui-base.css)
mobileangular-ui (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/js/mobile-angular-ui.js)
r.js (see ./usage/jsgui/src/build/requirejs-maven-plugin/r.js)
angular (see
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/angular-1.2.19)
I didn’t have time to check the connivence binaries.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
