On 28 September 2014 15:24, sebb <seb...@gmail.com> wrote: > On 26 September 2014 19:03, jan i <j...@apache.org> wrote: > > On 26 September 2014 19:23, Roman Shaposhnik <ro...@shaposhnik.org> > wrote: > > > >> Just like Ross, the following constitutes my personal opinion > >> (that has been formed over the years of maintaining complex > >> code bases written "before my time"): > >> > >> On Fri, Sep 26, 2014 at 10:04 AM, Ross Gardler (MS OPEN TECH) > >> <ross.gard...@microsoft.com> wrote: > >> > OK. I will give you my personal opinion since you are seeking to drive > >> consensus... > >> > > >> > I would say that if the code is of sufficient quality and relevance > for > >> the project to want > >> > to accept it then contributors should be given commit rights. > >> > >> I would even go further than this: to me a brand new code donation > >> without anybody donating that code willing to sign up to maintain > >> it (at least for as long as it takes for others to ramp up) spells > orphaned > >> code. > >> > >> IOW, for sizable brand new contribution the commit rights of somebody > >> familiar with the code shouldn't be a question, but more of a > prerequisite > >> to actually accepting that contribution in the first place. > >> > > my personal opion is a big +1 to not accepting bigger contributions if > the > > programmers (or at least part of them) comes along. > > I assume you meant: > > "unless the ... comes along" > or > "if the ... do not come along" > Thanks sebb for catching that typo. Yes I meant:
"my personal opion is a big +1 to not accepting bigger contributions if the programmers (or at least part of them) do not come along." thanks jan i. > > > Getting new code > > without people that understand it deeply, is really asking for trouble. > > > > rgds > > jan I. > > > > > > > > > >> Thanks, > >> Roman. > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
