On Sat, Aug 23, 2014 at 6:19 PM, Roman Shaposhnik <ro...@shaposhnik.org> wrote:
> On Sat, Aug 23, 2014 at 3:14 PM, John D. Ament <john.d.am...@gmail.com> > wrote: > > I'm not sure that I'm comfortable with the fact that all of your source > > code is under net.hydromatic.optiq rather than org.apache.optiq. Your > > apache headers also look a bit weird. Every other apache licensed that > > I've seen looks like [1], rather than your mix of single line and multi > > line headers. But I think that's just a preference thing. > > > > I'd like to get other's opinions on your package naming. > > Doing this kind of re-factoring of existing code base is part of the > incubation > process. This is a continuous process though. We expect podlings to finish > it before graduation, but I don't think we should discourage releases that > are not quite there yet. > Then they have my +1 (binding) for the release, package name was the only issue I noted. :-) - John > > Thanks, > Roman. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
